Codecov Report

Merging #30 into master will decrease coverage by 1.43%.
The diff coverage is 12.5%.

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   88.72%   87.29%   -1.44%     
==========================================
  Files           2        2              
  Lines         417      425       +8     
  Branches       71       72       +1     
==========================================
+ Hits          370      371       +1     
- Misses         26       32       +6     
- Partials       21       22       +1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5eacb7...75599e3. Read the comment docs.

This would be awesome to have! I just have a couple of minor comments on the changes. Thanks!

This looks good to me. @ryan-pip I assume you were able to give this a test run? I haven't done so due to the elaborate setup required.

@ashafer01 do you have any input? If not, I think this is good to merge.

Yes, i was able to give it a test run. Did a run in a clean env using pip to install and was missing a lib in setup.py but fixed now.

Two very minor suggestions:

• We should standardize on using "win" in sys.platform or platform.system() == 'Windows'
• We should explicitly perform the capitalization monkey patch in the test module as well rather than letting it happen implicitly by importing the mechanisms module.

👍 with or without these

Does anyone have preference one way or another which way we standardise?

If we apply the monkey patch in the test and then removed it in the code wouldn’t we end up with a test that would pass and a module that would fail?

Good point about the test, yeah let's not do that.

platform.system() feels more robust to me but I have no experience with using either solution.

I also prefer platform.system(), so I've replaced the check in setup.py to standardize on that.

Sounds like we're all on the same page. I'll merge at the end of the day if there are no objections.